feat: add podcast support to WorkPageButtons component #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamik10
approved these changes
Dec 9, 2024
| @@ -56,6 +55,20 @@ const WorkPageButtons = ({ workId }: WorkPageButtonsProps) => { | |||
| </Button> | |||
| </> | |||
| )} | |||
| {isPodcast(selectedManifestation) && ( | |||
There was a problem hiding this comment.
Would it make sense to use the same button that we use for AudioBook here too? And then just switch the material type in the ariaLabel and the inner Button text depending on isAudioBook and isPodcast.
There was a problem hiding this comment.
I think I like having them separated. This is because at some point they might introduce another material type or condition to consider. Also it is more readable in this way IMO. But I understand your point, I was a bit back and forward on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/jira/software/c/projects/DDFBRA/boards/498?assignee=712020%3Abfac20a1-e872-46b1-afff-2f008a684012&selectedIssue=DDFBRA-245
Description
Add support to try for podcast on workpage